Enable warnings for the native cc rules & symbols #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvadehra
force-pushed
the
rules_cc_warnings
branch
from
ca76774 to
f18e593
Compare
hvadehra
requested review from
vladmos,
pmbethe09 and
larsrc-google
as code owners
hvadehra
force-pushed
the
rules_cc_warnings
branch
from
f18e593 to
ca0b009
Compare
comius
approved these changes
Jan 23, 2025
vladmos
reviewed
Jan 23, 2025
hvadehra
force-pushed
the
rules_cc_warnings
branch
2 times, most recently
from
7698bee to
ec50ee8
Compare
hvadehra
force-pushed
the
rules_cc_warnings
branch
from
ec50ee8 to
77867e9
Compare
|
Friendly ping @vladmos |
|
Has something changed since #923 ? I thought the consensus was to not enable this by default? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.