-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Dockerfile for new Bazel releases #1290
Conversation
Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
fb3d993
to
49b9753
Compare
cc @alexeagle |
Cool, could you say something about the methodology you used to make it similar to images previously published with Bazel releases? |
Testing this out a bit - looks like the |
@alexeagle since Python 2 is already past EOL, I'm installing only Python 3. Do we need to symlink |
Thank you so much for this contribution. I think it can't hurt to have |
That newest one worked for me to build Bazel 5.0.0rc3 inside the container 👍🏻 |
Rolling back to Ubuntu 16.04 since linking against the newer glibc on 20.04 breaks running @alexeagle's Bazel 5.0.0rc3 on older systems. |
Ubuntu 16 matches what l.gcr.io/bazel:latest has as well, so we are just changing one thing at a time :) |
Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
Some random comments from an outsider:
Still, useful code and the direction seems right! |
@meteorcloudy this is ready for review, PTAL |
Looks good to me, @philwo Can you do the final check? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added two comments, but feel free to address them in a follow-up.
Thank you so much for preparing this!
"https://github.com/bazelbuild/bazel/releases/download/${BAZEL_VERSION}/bazel-${BAZEL_VERSION}-linux-x86_64.sha256" \ | ||
| sha256sum --check | ||
|
||
mv "bazel-${BAZEL_VERSION}-linux-x86_64" bazel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this architecture aware to support containers that work on arm64, too?
build-essential \ | ||
curl \ | ||
git \ | ||
openjdk-8-jdk \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use OpenJDK 11 now? Bazel itself at least no longer supports JDK 8 (although I think you can still use it to build stuff).
@meteorcloudy do you have the next steps for publishing Bazel 5 to gcr? |
I can setup a CI pipeline to regularly update the docker image for each Bazel LTS release after merging this. |
@meteorcloudy how about manually pushing a recent Bazel, if the automation is too much work to prioritize right now? |
Sorry for the delay here. I want to keep publishing to marketplace.gcr.io/google/bazel, but this is synced with a repo that's owned by a different Google team, I tried to migrate the staging repo to gcr.io/bazel-public/bazel, but that process hasn't gone well. Maybe I can first push to gcr.io/bazel-public/bazel, then people can pull docker images from the new URL? |
I have built and pushed images for all missing Bazel release versions to |
@meteorcloudy would love to see a bazel 5.2 gcr.io/bazel-public/bazel image ✌️ |
5.2 is already on |
Vulnerabilities has been detected in the docker images built from this Dockerfile, for example |
It would be great if 5.3 is on |
@tetsuok Pushed! |
@meteorcloudy Great! Thank you very much! |
Part of #1060.
Used dive to analyse the previously released image. There are still some packages that I may be missing from the 3.x release series.
Let me know if you spot any missing packages.