Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protobuf.yml #1293

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Update protobuf.yml #1293

merged 1 commit into from
Dec 14, 2021

Conversation

meteorcloudy
Copy link
Member

Add --proto_toolchain_for_cc=//:cc_toolchain to work around bazelbuild/bazel#10590 (comment)

Add `--proto_toolchain_for_cc=//:cc_toolchain` to work around bazelbuild/bazel#10590 (comment)
@meteorcloudy
Copy link
Member Author

FYI @Wyverald @Yannic

Copy link
Contributor

@Yannic Yannic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Should the file be moved into the protobuf repo?

@meteorcloudy
Copy link
Member Author

Should the file be moved into the protobuf repo?

Ideally yes, do you think that would encourage them to better maintain the Bazel build? For example, the window tests are currently failing https://buildkite.com/bazel/protobuf/builds/4000#_

@meteorcloudy meteorcloudy merged commit 8de02ee into master Dec 14, 2021
@meteorcloudy meteorcloudy deleted the meteorcloudy-patch-3 branch December 14, 2021 17:08
fmeum pushed a commit to fmeum/continuous-integration that referenced this pull request Dec 10, 2023
Add `--proto_toolchain_for_cc=//:cc_toolchain` to work around bazelbuild/bazel#10590 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants