Remove --incompatible_package_name_is_a_function from Android Testing #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flag has been removed; these tests are now expected to fail with the PACKAGE_NAME failure from upstream protobuf 3.4.1. The workaround is to update to protobuf 3.6.1.2 when it is released.
meteorcloudy
approved these changes
Dec 6, 2018
joeleba
pushed a commit
to joeleba/continuous-integration
that referenced
this pull request
Jun 17, 2019
…bazelbuild#417) The flag has been removed; these tests are now expected to fail with the PACKAGE_NAME failure from upstream protobuf 3.4.1. The workaround is to update to protobuf 3.6.1.2 when it is released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flag has been removed; these tests are now expected to fail with the PACKAGE_NAME failure from upstream protobuf 3.4.1.
The workaround is to update android/android-test to protobuf 3.6.1.2 when it is released, and update googlesamples/android-testing to use the updated android/android-test.
ref: bazelbuild/bazel#5827
cc @laurentlb