Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add gcc toolchain example #355

Merged
merged 4 commits into from
Nov 3, 2023
Merged

feat: add gcc toolchain example #355

merged 4 commits into from
Nov 3, 2023

Conversation

f0rmiga
Copy link
Contributor

@f0rmiga f0rmiga commented Oct 31, 2023

No description provided.

@f0rmiga f0rmiga requested a review from oquenchil as a code owner October 31, 2023 22:27
@alexeagle
Copy link
Collaborator

@f0rmiga do you have a suggestion where I should start to green this up by getting mac and windows to fall through to the system toolchain?

@f0rmiga
Copy link
Contributor Author

f0rmiga commented Nov 1, 2023

@f0rmiga do you have a suggestion where I should start to green this up by getting mac and windows to fall through to the system toolchain?

I can take that up later tonight and make it green!

@alexeagle alexeagle self-requested a review November 3, 2023 14:00
alexeagle
alexeagle approved these changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@alexeagle alexeagle enabled auto-merge (squash) November 3, 2023 14:05
@alexeagle alexeagle merged commit 2857511 into bazelbuild:main Nov 3, 2023
@inmcm inmcm mentioned this pull request Dec 12, 2023
Open
@Wyverald
Copy link
Member

Wyverald commented Aug 6, 2024

Bit late to the party, but I'm trying to migrate the C++ tutorial to use Bzlmod. Are there plans to make aspect_gcc_toolchain a module?

In any case, I feel like the stage0 here isn't really what a first-timer wants to see. Sure it's useful to set up a hermetic toolchain, or to know how to cross-compile, but that's really advanced stuff considering stage1 is literally a "hello world".

I'd rather we revert this change and put the gcc toolchain in a separate tutorial instead (or maybe as a stage4). WDYT? @alexeagle @f0rmiga

Wyverald added a commit that referenced this pull request Aug 20, 2024
@Wyverald
Revert "feat: add gcc toolchain example (#355)"
09068c5 
This reverts commit 2857511.
@Wyverald Wyverald mentioned this pull request Aug 20, 2024
Merged
@alexeagle
Copy link
Collaborator

Agree it doesn't have to be hermetic from the start, and that's not the typical developer path today. I can add stage4 with the llvm toolchain.

Wyverald added a commit that referenced this pull request Aug 22, 2024
@Wyverald
Revert "feat: add gcc toolchain example" (#485)
6583c1a 
Reverts #355

See
#355 (comment).
Discussed in the rules SIG meeting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@oquenchil oquenchil Awaiting requested review from oquenchil oquenchil is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@f0rmiga @alexeagle @Wyverald