Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support go_transition_test kind #3627

Closed
wants to merge 2 commits into from
Closed

Conversation

fkorotkov
Copy link
Contributor

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: bazel-contrib/rules_go#3160

Description of this change

If a go_test has, for example, race turned on than rules_go will transition the original target into a new one with a new kind. This change adds support for it.

@fmeum
Copy link
Contributor

fmeum commented Jul 31, 2022

@fkorotkov Could you check whether this is still needed? We got rid of go_transition_test in the latest rules_go release.

@fkorotkov fkorotkov closed this Aug 1, 2022
@fkorotkov fkorotkov deleted the patch-1 branch August 1, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants