Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS CI Runner #6624

Merged
merged 6 commits into from
Aug 29, 2024
Merged

Conversation

LeFrosch
Copy link
Collaborator

@LeFrosch LeFrosch commented Aug 8, 2024

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: <please reference the issue number or url here>

Description of this change

Adds a MacOS runner for CLion. As far as I can tell, all test work on MacOS including the integration tests.

@LeFrosch LeFrosch force-pushed the Daniel.Brauner/macos-runner branch 7 times, most recently from 293fccf to 60adaf6 Compare August 9, 2024 16:01
@LeFrosch LeFrosch force-pushed the Daniel.Brauner/macos-runner branch from ea92ba3 to 105be18 Compare August 9, 2024 17:20
maybe they do not have a broken system rc file :(
@LeFrosch LeFrosch force-pushed the Daniel.Brauner/macos-runner branch from 4e44611 to 2cd9bbf Compare August 9, 2024 19:14
@LeFrosch
Copy link
Collaborator Author

System rc file on MacOS runners causes tests failures for older bazel versions. Maybe fixed by bazel-contrib/rules_bazel_integration_test#349

@LeFrosch LeFrosch force-pushed the Daniel.Brauner/macos-runner branch from 11948ec to be85d11 Compare August 22, 2024 19:14
@LeFrosch LeFrosch force-pushed the Daniel.Brauner/macos-runner branch from be85d11 to 4b01dd2 Compare August 22, 2024 19:20
@LeFrosch LeFrosch marked this pull request as ready for review August 22, 2024 19:24
@github-actions github-actions bot added product: CLion CLion plugin awaiting-review Awaiting review from Bazel team on PRs labels Aug 22, 2024
@LeFrosch LeFrosch merged commit d63c6d5 into bazelbuild:master Aug 29, 2024
8 checks passed
@LeFrosch LeFrosch deleted the Daniel.Brauner/macos-runner branch August 29, 2024 12:24
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: CLion CLion plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants