Return sorted sets (follow-up to #7198) #7314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odisseus
requested review from
mai93,
ujohnny,
LeFrosch and
agluszak
as code owners
github-actions
bot
added
product: CLion
|
If I remember correctly, it was a set before. Do we introduce duplicates by moving from a set to a list? Maybe keep it a set if we don't want duplicates. But overall, I think it is a good idea going back to immutable here. |
|
The chance from Set to List was introduced in #7198. I think the idea was that the collection of targets should be ordered, and that well-known kinds should have precedence. |
LeFrosch
approved these changes
Feb 12, 2025
odisseus
force-pushed
the
issue-7196-2
branch
from
135d6dd to
a733ade
Compare
|
Not sure, in this case we might be able to drop the sort call too? Nvm, apparently I cannot read diffs. |
LeFrosch
approved these changes
Feb 12, 2025
odisseus
changed the title
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number: #7198
Description of this change
Immutability of collections that we return is an important part of the contract.