Release: java_tools v13.3 #86

keertk · 2023-11-27T16:17:36Z

Link to relevant issue and/or commit:

Other details:
N/A

The text was updated successfully, but these errors were encountered:

keertk · 2023-11-27T21:52:53Z

Step 2:
https://buildkite.com/bazel-trusted/java-tools-binaries-java/builds/235

Step 3:
COMMIT_HASH: 92d19ee3c346fd904bb5be68026c2be4914db340

...in progress
(currently blocked by failures)

keertk · 2023-11-28T14:32:21Z

Update: This is on hold until the network issues are resolved.
(cc @hvadehra)

fmeum · 2023-11-28T14:52:50Z

@keertk Could we make this rules_java 7.3.1? The turbine changes are bug fixes for regressions introduced by 7.3.0.

keertk · 2023-11-28T14:58:15Z

@fmeum Sure. Is the same true for these changes as well? Or do we need separate releases?

fmeum · 2023-11-28T15:20:42Z

@fmeum Sure. Is the same true for these changes as well? Or do we need separate releases?

Yes, those are exactly the turbine fixes I was referring to.

hvadehra · 2023-11-30T07:17:39Z

For some reason the newly added test (test_header_compiler_direct_supports_release) fails, but only for darwin arm64 (which we didn't test for while merging the change):

FAILED: test_header_compiler_direct_supports_release

ERROR: /private/var/tmp/_bazel_buildkite/febd3a7cb30f371618a049296da6e0a9/sandbox/darwin-sandbox/4063/execroot/_main/_tmp/e5441b83c301643fae8009ed9b94bd78/workspace/pkg/BUILD:2:13: Compiling Java headers pkg/libb-hjar.jar (1 source file) failed: (Exit 1): turbine_direct_graal failed: error executing Turbine command (from target //pkg:b) external/rules_java~7.3.0~toolchains~remote_java_tools_darwin_arm64/java_tools/turbine_direct_graal '-Dturbine.ctSymPath=external/rules_java~7.3.0~toolchains~remotejdk21_macos_aarch64/lib/ct.sym' ... (remaining 30 arguments skipped)
 
Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
java.lang.NullPointerException: attempted to use --release, but JAVA_HOME is not set
	at java.base@20.0.2/java.util.Objects.requireNonNull(Objects.java:259)
	at com.google.turbine.binder.CtSymClassBinder.bind(CtSymClassBinder.java:52)
	at com.google.turbine.main.Main.bootclasspath(Main.java:309)
	at com.google.turbine.main.Main.compile(Main.java:142)
	at com.google.turbine.main.Main.compile(Main.java:133)
	at com.google.turbine.main.Main.main(Main.java:89)
Target //pkg:a failed to build

@fmeum any ideas?

fmeum · 2023-11-30T07:22:46Z

@hvadehra Yes, that's because there was no override for darwin_arm64 and I also didn't include it with my PR. This should be fixed by adding a corresponding line here and in the other tests with this setup:
https://github.com/bazelbuild/bazel/blob/4a29f0851d1cde0240793cdc7a2e2cab926d31b7/src/test/shell/bazel/bazel_java_test.sh#L82

hvadehra · 2023-11-30T07:34:10Z

Ah, just a typo s/remote_java_tools_arm64/remote_java_tools_darwin_arm64/

See bazelbuild/java_tools#86 (comment) Closes #20374. PiperOrigin-RevId: 586571655 Change-Id: I7b43c2fa1dc2e1cef71e72baf7ec8f2b84070f50

keertk · 2023-11-30T17:55:52Z

Step 2:
https://buildkite.com/bazel-trusted/java-tools-binaries-java/builds/242

Step 3:
COMMIT_HASH: 4b13eee7b45a06fca1224ab5ce04d3e937ce35b0

Step 4:

{
  "version": "v13.3",
  "release": "false",
  "artifacts": {
    "java_tools_linux": {
      "mirror_url": "https://mirror.bazel.build/bazel_java_tools/release_candidates/java/v13.3/java_tools_linux-v13.3-rc1.zip",
      "sha": "a781eb28bb28d1fd9eee129272f7f2eaf93cd272f974a5b3f6385889538d3408"
    },
    "java_tools_windows": {
      "mirror_url": "https://mirror.bazel.build/bazel_java_tools/release_candidates/java/v13.3/java_tools_windows-v13.3-rc1.zip",
      "sha": "8fc29a5e34e91c74815c4089ed0f481a7d728a5e886c4e5e3b9bcd79711fee3d"
    },
    "java_tools_darwin_x86_64": {
      "mirror_url": "https://mirror.bazel.build/bazel_java_tools/release_candidates/java/v13.3/java_tools_darwin_x86_64-v13.3-rc1.zip",
      "sha": "55bd36bf2fad897d9107145f81e20a549a37e4d9d4c447b6915634984aa9f576"
    },
    "java_tools_darwin_arm64": {
      "mirror_url": "https://mirror.bazel.build/bazel_java_tools/release_candidates/java/v13.3/java_tools_darwin_arm64-v13.3-rc1.zip",
      "sha": "276bb552ee03341f93c0c218343295f60241fe1d32dccd97df89319c510c19a1"
    },
    "java_tools": {
      "mirror_url": "https://mirror.bazel.build/bazel_java_tools/release_candidates/java/v13.3/java_tools-v13.3-rc1.zip",
      "sha": "30a7d845bec3dd054ac45b5546c2fdf1922c0b1040b2a13b261fcc2e2d63a2f4"
    }
  }
}

Step 5:
Commit:
bazelbuild/rules_java@2c45d34
2c45d348376c1e302fd6534de38a9b6c570493f2

Step 6 / 7:
PR: bazelbuild/bazel#20393
Presubmit: https://buildkite.com/bazel/bazel-bazel-github-presubmit/builds/18721

Step 8:
Downstream build: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/3463

Step 9:

{
  "version": "v13.3",
  "release": "true",
  "artifacts": {
    "java_tools_linux": {
      "mirror_url": "https://mirror.bazel.build/bazel_java_tools/releases/java/v13.3/java_tools_linux-v13.3.zip",
      "github_url": "https://github.com/bazelbuild/java_tools/releases/download/java_v13.3/java_tools_linux-v13.3.zip",
      "sha": "a781eb28bb28d1fd9eee129272f7f2eaf93cd272f974a5b3f6385889538d3408"
    },
    "java_tools_windows": {
      "mirror_url": "https://mirror.bazel.build/bazel_java_tools/releases/java/v13.3/java_tools_windows-v13.3.zip",
      "github_url": "https://github.com/bazelbuild/java_tools/releases/download/java_v13.3/java_tools_windows-v13.3.zip",
      "sha": "8fc29a5e34e91c74815c4089ed0f481a7d728a5e886c4e5e3b9bcd79711fee3d"
    },
    "java_tools_darwin_x86_64": {
      "mirror_url": "https://mirror.bazel.build/bazel_java_tools/releases/java/v13.3/java_tools_darwin_x86_64-v13.3.zip",
      "github_url": "https://github.com/bazelbuild/java_tools/releases/download/java_v13.3/java_tools_darwin_x86_64-v13.3.zip",
      "sha": "55bd36bf2fad897d9107145f81e20a549a37e4d9d4c447b6915634984aa9f576"
    },
    "java_tools_darwin_arm64": {
      "mirror_url": "https://mirror.bazel.build/bazel_java_tools/releases/java/v13.3/java_tools_darwin_arm64-v13.3.zip",
      "github_url": "https://github.com/bazelbuild/java_tools/releases/download/java_v13.3/java_tools_darwin_arm64-v13.3.zip",
      "sha": "276bb552ee03341f93c0c218343295f60241fe1d32dccd97df89319c510c19a1"
    },
    "java_tools": {
      "mirror_url": "https://mirror.bazel.build/bazel_java_tools/releases/java/v13.3/java_tools-v13.3.zip",
      "github_url": "https://github.com/bazelbuild/java_tools/releases/download/java_v13.3/java_tools-v13.3.zip",
      "sha": "30a7d845bec3dd054ac45b5546c2fdf1922c0b1040b2a13b261fcc2e2d63a2f4"
    }
  }
}

Step 10:
java_tools released: https://github.com/bazelbuild/java_tools/releases/tag/java_v13.3

Step 11:
rules_java PR: bazelbuild/rules_java#157

Step 12:
rules_java released: https://github.com/bazelbuild/rules_java/releases/tag/7.3.1
BCR PR: bazelbuild/bazel-central-registry#1163

keertk · 2023-12-01T17:13:12Z

Done -
https://github.com/bazelbuild/java_tools/releases/tag/java_v13.3
https://github.com/bazelbuild/rules_java/releases/tag/7.3.1

keertk added P1 I'll work on this now. (Assignee required) release labels Nov 27, 2023

keertk assigned sgowroji, iancha1992 and keertk and unassigned sgowroji and iancha1992 Nov 27, 2023

keertk mentioned this issue Nov 28, 2023

Pass ct.sym to direct version of Turbine bazelbuild/bazel#20294

Closed

fmeum mentioned this issue Nov 30, 2023

Fix typo in repo overrides for darwin_arm64 Java tools in tests bazelbuild/bazel#20374

Closed

keertk closed this as completed Dec 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release: java_tools v13.3 #86

Release: java_tools v13.3 #86

keertk commented Nov 27, 2023 •

edited

Loading

keertk commented Nov 27, 2023 •

edited

Loading

keertk commented Nov 28, 2023

fmeum commented Nov 28, 2023

keertk commented Nov 28, 2023 •

edited

Loading

fmeum commented Nov 28, 2023

hvadehra commented Nov 30, 2023

fmeum commented Nov 30, 2023 •

edited

Loading

hvadehra commented Nov 30, 2023

keertk commented Nov 30, 2023 •

edited

Loading

keertk commented Dec 1, 2023

Release: java_tools v13.3 #86

Release: java_tools v13.3 #86

Comments

keertk commented Nov 27, 2023 • edited Loading

keertk commented Nov 27, 2023 • edited Loading

keertk commented Nov 28, 2023

fmeum commented Nov 28, 2023

keertk commented Nov 28, 2023 • edited Loading

fmeum commented Nov 28, 2023

hvadehra commented Nov 30, 2023

fmeum commented Nov 30, 2023 • edited Loading

hvadehra commented Nov 30, 2023

keertk commented Nov 30, 2023 • edited Loading

keertk commented Dec 1, 2023

keertk commented Nov 27, 2023 •

edited

Loading

keertk commented Nov 27, 2023 •

edited

Loading

keertk commented Nov 28, 2023 •

edited

Loading

fmeum commented Nov 30, 2023 •

edited

Loading

keertk commented Nov 30, 2023 •

edited

Loading