Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proposal for support C++20 Modules #354

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

PikachuHyA
Copy link
Contributor

No description provided.

@PikachuHyA PikachuHyA requested review from jin and lberki as code owners October 25, 2023 11:04
@google-cla
Copy link

google-cla bot commented Oct 25, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@lberki
Copy link
Contributor

lberki commented Oct 25, 2023

Mind linking this into README.md under the "under review" section?

@lberki
Copy link
Contributor

lberki commented Oct 26, 2023

Thanks! It appears that you also need to sign our CLA (I missed this yesterday, sorry about that)

My understanding is that you work for Alibaba and my data shows that Alibaba Group already has a corporate CLA signed, which means that you should be covered, but our bot seems to disagree. Instructions are here to fix it; you probably either need to add the e-mail address to the set of people covered by your CLA or use a different e-mail on your git commit.

Sorry about the red tape.

@PikachuHyA
Copy link
Contributor Author

PikachuHyA commented Oct 30, 2023

It appears that you also need to sign our CLA

done

@lberki
Copy link
Contributor

lberki commented Oct 30, 2023

Thanks! I'll merge this now.

@lberki lberki merged commit d32f162 into bazelbuild:main Oct 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants