Skip to content

Commit

Permalink
Fix Rebase
Browse files Browse the repository at this point in the history
  • Loading branch information
rubensf committed Nov 23, 2020
1 parent c4f35fa commit 25688f6
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 10 deletions.
22 changes: 13 additions & 9 deletions go/pkg/reader/reader.go
Original file line number Diff line number Diff line change
Expand Up @@ -146,21 +146,22 @@ func (cfs *compressedSeeker) Read(p []byte) (int, error) {
// errW must be non-nil if written bytes != from n.
_, errW = cfs.encd.Write(p[:n])
}
m, err := cfs.buf.Read(p)
m, errR2 := cfs.buf.Read(p)

var retErr error
if errR == io.EOF {
cfs.encd.Close()
} else if errR != nil {
if errR != nil {
retErr = errR
}
if retErr == nil && errW != nil {
} else if errW != nil {
retErr = errW
} else {
retErr = errR2
}
if retErr == nil {
retErr = err

if retErr != nil {
cfs.encd.Close()
}
return m, err

return m, retErr
}

func (cfs *compressedSeeker) SeekOffset(offset int64) error {
Expand All @@ -179,3 +180,6 @@ func (cfs *compressedSeeker) SeekOffset(offset int64) error {

func (cfs *compressedSeeker) IsInitialized() bool { return cfs.fs.IsInitialized() }
func (cfs *compressedSeeker) Initialize() error { return cfs.fs.Initialize() }

// The compressor is already closed on EOF on Read.
func (cfs *compressedSeeker) Close() error { return cfs.fs.Initialize() }
2 changes: 1 addition & 1 deletion go/pkg/reader/reader_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ func TestCompressedReader(t *testing.T) {
t.Run(name, func(t *testing.T) {
t.Parallel()

path, err := test_util.CreateFile(t, false, blob)
path, err := testutil.CreateFile(t, false, blob)
if err != nil {
t.Fatalf("Failed to initialize temp file: %v", err)
}
Expand Down

0 comments on commit 25688f6

Please sign in to comment.