Optimise out uploading the empty blob in a couple of places #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ola-rozenfeld
approved these changes
Sep 23, 2020
|
Can you please rebase? Thank you! |
peterebden
force-pushed
the
skip-empty-blob-upload
branch
from
191e9de
to
a175914
Compare
|
Apologies for the delay - have rebased. |
| @@ -597,6 +601,9 @@ func (c *Client) ResourceNameWrite(hash string, sizeBytes int64) string { | |||
| // GetDirectoryTree returns the entire directory tree rooted at the given digest (which must target | |||
| // a Directory stored in the CAS). | |||
| func (c *Client) GetDirectoryTree(ctx context.Context, d *repb.Digest) (result []*repb.Directory, err error) { | |||
| if d.SizeBytes == 0 && d.Hash == digest.Empty.Hash { | |||
| return nil, nil | |||
There was a problem hiding this comment.
Wait, is that correct? Shouldn't this return an empty Directory proto?
There was a problem hiding this comment.
It's returning a slice of directory protos, so nil is pretty equivalent to an empty slice here.
There was a problem hiding this comment.
Yes, but I mean: shouldn't it return a slice containing one item, []*repb.Directory{&repb.Directory{}}, instead? An empty digest maps to an empty directory.
ola-rozenfeld
pushed a commit
to ola-rozenfeld/remote-apis-sdks
that referenced
this pull request
Feb 18, 2021
ola-rozenfeld
pushed a commit
to ola-rozenfeld/remote-apis-sdks
that referenced
this pull request
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per bazelbuild/remote-apis#131 there is no longer any requirement to upload the empty blob since the server must provide it. This optimises it out in a couple of places to make callers' life a bit easier.