Skip to content

Commit

Permalink
Servers must provide empty blobs that weren't uploaded
Browse files Browse the repository at this point in the history
Some clients refer to empty blobs without previously uploading them, as a
performance optimization. Servers must support this.

Perhaps we can improve on this for REAPIv3, eg require that empty blobs be
represented by null Digests.
  • Loading branch information
mostynb committed Apr 16, 2020
1 parent 67e8026 commit 26c67c2
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions build/bazel/remote/execution/v2/remote_execution.proto
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,10 @@ service ActionCache {
// used in subsequent calls (e.g. to
// [Execute][build.bazel.remote.execution.v2.Execution.Execute]).
//
// Servers MUST behave as though empty blobs are always available, even if they
// have not been uploaded. Clients MAY optimize away the uploading or
// downloading of empty blobs.
//
// As with other services in the Remote Execution API, any call may return an
// error with a [RetryInfo][google.rpc.RetryInfo] error detail providing
// information about when the client should retry the request; clients SHOULD
Expand Down

0 comments on commit 26c67c2

Please sign in to comment.