Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecated usage of go_package option in proto files #181

Closed
tdyas opened this issue Nov 17, 2020 · 1 comment · Fixed by #219
Closed

deprecated usage of go_package option in proto files #181

tdyas opened this issue Nov 17, 2020 · 1 comment · Fixed by #219

Comments

@tdyas
Copy link

tdyas commented Nov 17, 2020

Warning from protoc v3.13.0 when generating bindings:

2020/11/17 13:15:49 WARNING: Deprecated use of 'go_package' option without a full import path in "build/bazel/semver/semver.proto", please specify:
	option go_package = "build/bazel/semver";
A future release of protoc-gen-go will require the import path be specified.
See https://developers.google.com/protocol-buffers/docs/reference/go-generated#package for more information.

2020/11/17 13:15:49 WARNING: Deprecated use of 'go_package' option without a full import path in "build/bazel/remote/execution/v2/remote_execution.proto", please specify:
	option go_package = "build/bazel/remote/execution/v2;remoteexecution";
A future release of protoc-gen-go will require the import path be specified.
See https://developers.google.com/protocol-buffers/docs/reference/go-generated#package for more information.
@EdSchouten
Copy link
Collaborator

Even the suggestion it provides is incomplete. We should use the following instead, right?

option go_package = "github.com/bazelbuild/remote-apis/build/bazel/semver";

jmillikin added a commit to jmillikin/remote-apis that referenced this issue Apr 12, 2022
@jmillikin
Use fully-qualified import paths in go_package options.
6bc4d57 
The Protobuf documentation for [`go_package`][1] requires that it
contain a fully-qualified import path, with an optional package
name override.

As of [CL 301953[2] (released in [protobuf-go v1.26][3]), this
requirement is being enforced by the `protoc-gen-go` plugin.

I set the `go_package` options such that there is no change to
generated code compared to the previous version. This required
overriding the package names for the `remoteasset`, `remoteexecution`,
and `remotelogstream` packages, since those have import paths ending
in `/v1` or `/v2`.

Fixes bazelbuild#181

[1] https://developers.google.com/protocol-buffers/docs/reference/go-generated#package
[2] https://go-review.googlesource.com/c/protobuf/+/301953/
[3] https://github.com/protocolbuffers/protobuf-go/releases/tag/v1.26.0
jmillikin added a commit to jmillikin/remote-apis that referenced this issue Apr 12, 2022
@jmillikin
Use fully-qualified import paths in go_package options.
81246b7 
The Protobuf documentation for [`go_package`][1] requires that it
contain a fully-qualified import path, with an optional package
name override.

As of [CL 301953][2] (released in [protobuf-go v1.26][3]), this
requirement is being enforced by the `protoc-gen-go` plugin.

I set the `go_package` options such that there is no change to
generated code compared to the previous version. This required
overriding the package names for the `remoteasset`, `remoteexecution`,
and `remotelogstream` packages, since those have import paths ending
in `/v1` or `/v2`.

Fixes bazelbuild#181

[1]: https://developers.google.com/protocol-buffers/docs/reference/go-generated#package
[2]: https://go-review.googlesource.com/c/protobuf/+/301953/
[3]: https://github.com/protocolbuffers/protobuf-go/releases/tag/v1.26.0
@jmillikin jmillikin mentioned this issue Apr 12, 2022
Merged
bergsieker pushed a commit that referenced this issue Apr 13, 2022
@jmillikin
Use fully-qualified import paths in go_package options. (#219)
2af1c43 
The Protobuf documentation for [`go_package`][1] requires that it
contain a fully-qualified import path, with an optional package
name override.

As of [CL 301953][2] (released in [protobuf-go v1.26][3]), this
requirement is being enforced by the `protoc-gen-go` plugin.

I set the `go_package` options such that there is no change to
generated code compared to the previous version. This required
overriding the package names for the `remoteasset`, `remoteexecution`,
and `remotelogstream` packages, since those have import paths ending
in `/v1` or `/v2`.

Fixes #181

[1]: https://developers.google.com/protocol-buffers/docs/reference/go-generated#package
[2]: https://go-review.googlesource.com/c/protobuf/+/301953/
[3]: https://github.com/protocolbuffers/protobuf-go/releases/tag/v1.26.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use fully-qualified import paths in go_package options. jmillikin/remote-apis
2 participants
@EdSchouten @tdyas