Moving node properties of a directory to the Directory message #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ola-rozenfeld
requested review from
agoulti,
bergsieker,
buchgr and
ulfjack
as code owners
googlebot
added
the
cla: yes
EdSchouten
reviewed
Oct 22, 2019
| @@ -689,9 +692,6 @@ message DirectoryNode { | |||
| // represented. See [Digest][build.bazel.remote.execution.v2.Digest] | |||
| // for information about how to take the digest of a proto message. | |||
| Digest digest = 2; | |||
|
|
|||
| // The node properties of the DirectoryNode. | |||
| repeated NodeProperty node_properties = 3; | |||
There was a problem hiding this comment.
I think these properties may also be removed from one or two other places (e.g., output directories).
There was a problem hiding this comment.
Right, thanks!
There was a problem hiding this comment.
I understand why properties should be added to the directory message but why are these being removed?
There was a problem hiding this comment.
Otherwise all directories except the top-level one would have two node_properties lists, and we should only need one per directory.
EdSchouten
approved these changes
Oct 22, 2019
|
@traveltissues, PTAL. Thank you! |
|
https://github.com/bazelbuild/remote-apis/pull/102/files#diff-4153f76ba92d8d30764c0251177105e8R655 |
bergsieker
approved these changes
Nov 2, 2019
santigl
pushed a commit
to santigl/remote-apis
that referenced
this pull request
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.