Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote_execution: add digest metadata #303

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sluongng
Copy link
Contributor

@sluongng sluongng commented Jul 9, 2024

Add optional routing metadata for REAPI RPCs.

These are plain-text HTTP headers that can be parsed by popular load balancers
or reverse proxy solutions such as Caddy and Nginx to route RPC requests to
appropriate server instances.

RPC requests referencing or containing a single blob can use the blob-digest
header to provide routing hint information.

RPC requests referencing or containing multiple blobs can use one blob, or
none, as a routing hint via the blob-digest header.

Add optional routing metadata for REAPI RPCs.

These are plain-text HTTP headers that can be parsed by popular load balancers
or reverse proxy solutions such as Caddy and Nginx to route RPC requests to
appropriate server instances.

RPC requests referencing or containing a single blob can use the `blob-digest`
header to provide routing hint information.

RPC requests referencing or containing multiple blobs can use one blob, or
none, as a routing hint via the `blob-digest` header.
@sluongng sluongng requested a review from bergsieker as a code owner July 9, 2024 14:03
// serialization:
//
// * name: `build.bazel.remote.execution.v2.blob-digest`
// * contents: the plained text digest of the blob in the form of "{hash}/{size}".
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of reinventing our own format for this string, any chance we can just reuse the existing bytestream path string? So prefixed with the instance name, potentially containing the digest function, etc.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case probably best to call this build.bazel.remote.execution.v2.resource-name?

//
// * name: `build.bazel.remote.execution.v2.blob-digest`
// * contents: the plained text digest of the blob in the form of "{hash}/{size}".
message BlobDigest {}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this message type actually needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants