Rename top-level BUILD to BUILD.bazel to avoid case-insensitive collision with "build" directory. #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasharpe
requested review from
agoulti,
bergsieker,
buchgr,
ola-rozenfeld and
ulfjack
as code owners
googlebot
added
the
cla: yes
…sion with "build" directory. I verified this by creating a simple Go project that imports remote-apis, and verified that I get the error and that this commit fixes it. Fixed bazelbuild#82.
ola-rozenfeld
approved these changes
May 28, 2019
mostynb
added a commit
to mostynb/remote-apis-sdks
that referenced
this pull request
Aug 14, 2019
In another project I noticed a mac build error in buildkite with the previous configuration claiming that repository_rules.bzl needed a matching BUILD file. Updating to the tip of master helped- I suspect due to bazelbuild/remote-apis#83
ifoox
pushed a commit
to bazelbuild/remote-apis-sdks
that referenced
this pull request
Aug 14, 2019
…#73) In another project I noticed a mac build error in buildkite with the previous configuration claiming that repository_rules.bzl needed a matching BUILD file. Updating to the tip of master helped- I suspect due to bazelbuild/remote-apis#83
santigl
pushed a commit
to santigl/remote-apis
that referenced
this pull request
Aug 26, 2020
Prepares for addition of a second connection to the CAS service in DialParams (bazelbuild#78). Also adding better named overloads for constructors in order to migrate users to these names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I verified this by creating a simple Go project that imports remote-apis, and verified that I get the error and that this commit fixes it.
Fixed #82.
In the future we should add CI. :)