Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Starlarkify android_sdk_repository #76

Closed
katre opened this issue May 2, 2023 · 1 comment
Closed

Starlarkify android_sdk_repository #76

katre opened this issue May 2, 2023 · 1 comment
Assignees
@katre
Labels
feature request New feature or request Roadmap Roadmap Item

Comments

@katre
Copy link
Member

katre commented May 2, 2023

We need a pure-Starlark version of android_sdk_repository in order to decouple upcoming Android platforms changes from bazel releases.

This also helps address bazelbuild/bazel#18285.
@katre katre mentioned this issue May 2, 2023
Closed
@ahumesky ahumesky added the feature request New feature or request label May 2, 2023
copybara-service bot pushed a commit that referenced this issue May 22, 2023
@katre @copybara-github
Add Android revision checking.
c9f5bca 
Part of #76.

PiperOrigin-RevId: 534173459
Change-Id: I3185985adee6256b81bbe7d9106641fe46894c48
@katre katre mentioned this issue May 23, 2023
Closed
@ted-xie ted-xie added the Roadmap Roadmap Item label Jul 26, 2023
katre added a commit to katre/rules_android that referenced this issue Aug 15, 2023
@katre
DO NOT SUBMIT
c729679 
Implement android_sdk_repository in Starlark.

Fixes bazelbuild#76.

PiperOrigin-RevId: 531575425
Change-Id: I1a17d21984429bf426c9ff3f8ba7cdab337c8529
katre added a commit to katre/rules_android that referenced this issue Aug 16, 2023
@katre
DO NOT SUBMIT
1d83177 
Implement android_sdk_repository in Starlark.

Fixes bazelbuild#76.

PiperOrigin-RevId: 531575425
Change-Id: Ia6acb8ab9b2d4a8fd7ea3da7edcb592454d85b52
copybara-service bot pushed a commit that referenced this issue Aug 16, 2023
@katre @copybara-github
Add a copy of bashunit.
e844f65 
Needed for tests of android_sdk_repository.

Part of #76.

PiperOrigin-RevId: 557560436
Change-Id: I1c904b2e3a3136819b3d6b3bc6ee49193aeebbce
copybara-service bot pushed a commit that referenced this issue Sep 6, 2023
@katre @copybara-github
Add a dependency on rules_bazel_integration_test.
bb96e31 
Also add a smoke test to confirm that it works properly.

Part of #76.

PiperOrigin-RevId: 563174586
Change-Id: Ic186af201f7c40aa3e42e9149b81fa13d662994b
@ahumesky
Copy link
Collaborator

We've moved rules_android to use the Starlark version of android_sdk_repository

jylinv0 pushed a commit to jylinv0/rules_android that referenced this issue Jan 23, 2024
@katre
Add Android revision checking.
b724a63 
Part of bazelbuild#76.

PiperOrigin-RevId: 534173459
Change-Id: I3185985adee6256b81bbe7d9106641fe46894c48
jylinv0 pushed a commit to jylinv0/rules_android that referenced this issue Jan 23, 2024
@katre
Add a copy of bashunit.
0b9e9eb 
Needed for tests of android_sdk_repository.

Part of bazelbuild#76.

PiperOrigin-RevId: 557560436
Change-Id: I1c904b2e3a3136819b3d6b3bc6ee49193aeebbce
jylinv0 pushed a commit to jylinv0/rules_android that referenced this issue Jan 23, 2024
@katre
Add a dependency on rules_bazel_integration_test.
d81b92d 
Also add a smoke test to confirm that it works properly.

Part of bazelbuild#76.

PiperOrigin-RevId: 563174586
Change-Id: Ic186af201f7c40aa3e42e9149b81fa13d662994b
jylinv0 pushed a commit to jylinv0/rules_android that referenced this issue Jan 23, 2024
@katre
Implement android_sdk_repository in Starlark.
0c2bb27 
Fixes bazelbuild#76.

PiperOrigin-RevId: 563532977
Change-Id: I1a17d21984429bf426c9ff3f8ba7cdab337c8529
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katre katre

Labels
feature request New feature or request Roadmap Roadmap Item
Projects
Starlark Android Rules
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@katre @ted-xie @ahumesky