Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Update BUILD #114

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Update BUILD #114

merged 1 commit into from
Apr 29, 2020

Conversation

codecakes
Copy link
Contributor

should this be full name?

full name?
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@codecakes
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@codecakes codecakes marked this pull request as ready for review April 29, 2020 13:37
@codecakes codecakes requested a review from pmbethe09 as a code owner April 29, 2020 13:37
Copy link
Member

@pmbethe09 pmbethe09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Good idea -- this works as in the same repo, but as an example, the full path makes more sense.

@pmbethe09 pmbethe09 merged commit bbe49a7 into bazelbuild:master Apr 29, 2020
@codecakes
Copy link
Contributor Author

LGTM

Good idea -- this works as in the same repo, but as an example, the full path makes more sense.

cool.
@pmbethe09 I was trying this out as a rule to deploy my project to gae when I ran into this error.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants