Skip to content

Commit

Permalink
enable asan, tsan, and ubsan because they work on the Skylark crosstool.
Browse files Browse the repository at this point in the history
bazelbuild/bazel#5380

WIP NOTES: Currently Under PY3 I'm seeing "ModuleNotFoundError: No module named 'macholib'". https://storage.googleapis.com/bazel-untrusted-buildkite-artifacts/e203259d-8963-405b-b285-c8353a5115ac/test/ios_application_clang_rt_test.simulator/attempt_1.log

RELNOTES: None
PiperOrigin-RevId: 262913436
  • Loading branch information
gabebear authored and swiple-rules-gardener committed Aug 12, 2019
1 parent c6d0b2c commit 11eef74
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions test/ios_application_clang_rt_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ EOF
}

# Tests that ASAN libraries and packaged into the IPA when enabled.
function disabled_test_asan_bundle() { # Blocked on b/73547309
function test_asan_bundle() {
create_common_files
create_minimal_ios_application

Expand All @@ -92,7 +92,7 @@ function disabled_test_asan_bundle() { # Blocked on b/73547309
fi
}

function disabled_test_tsan_bundle() { # Blocked on b/73547309
function test_tsan_bundle() {
# Skip the device version as tsan is not supported on devices.
if ! is_device_build ios ; then
create_common_files
Expand All @@ -105,7 +105,7 @@ function disabled_test_tsan_bundle() { # Blocked on b/73547309
fi
}

function disabled_test_ubsan_bundle() { # Blocked on b/73547309
function test_ubsan_bundle() {
create_common_files
create_minimal_ios_application

Expand Down
4 changes: 2 additions & 2 deletions test/ios_application_swift_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ EOF

# Tests that swift_library build with ASAN enabled and that the ASAN
# library is packaged into the IPA when enabled.
function disabled_test_swift_builds_with_asan() { # Blocked on b/73547309
function test_swift_builds_with_asan() {
create_minimal_ios_application

cat >> app/BUILD <<EOF
Expand All @@ -198,7 +198,7 @@ EOF

# Tests that swift_library build with TSAN enabled and that the TSAN
# library is packaged into the IPA when enabled.
function disabled_test_swift_builds_with_tsan() { # Blocked on b/73547309
function test_swift_builds_with_tsan() {
# Skip the device version as tsan is not supported on devices.
if ! is_device_build ios ; then
create_minimal_ios_application
Expand Down

0 comments on commit 11eef74

Please sign in to comment.