Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add override_archs to macos_command_line_application #1155

Closed

Conversation

keith
Copy link
Member

@keith keith commented May 10, 2021

This allows you to specify that the rule be built for multiple
architectures and produce a fat binary. This is useful to force binaries
to be share-able between Apple Silicon and Intel machines which is
useful for making sure host tools don't invalidate caches.

This allows you to specify that the rule be built for multiple
architectures and produce a fat binary. This is useful to force binaries
to be share-able between Apple Silicon and Intel machines which is
useful for making sure host tools don't invalidate caches.
@google-cla google-cla bot added the cla: yes label May 10, 2021
@keith
Copy link
Member Author

keith commented May 10, 2021

Submitting as an example alternative to bazelbuild/bazel#13461

@keith
Copy link
Member Author

keith commented May 10, 2021

Besides the rule changed here I'm not really sure which you'd want to have this functionality for, so maybe it would be fine to do this and require users to add the attr to each of their tools as opposed to passing the global flag, I'm not sure.

@brentleyjones
Copy link
Collaborator

I can see a need for both this and bazelbuild/bazel#13461. This can be used to undo a global setting. I could see the global setting being a very normal thing (enough that I think the default should be both x86 and arm, and you would use the flag to undo it if you didn't need it).

@keith
Copy link
Member Author

keith commented Nov 5, 2021

Looks like 73c041d will help this use case

@keith
Copy link
Member Author

keith commented Feb 15, 2022

There is now the universal rule for this instead

@keith keith closed this Feb 15, 2022
@keith keith deleted the ks/add-override_archs-to-macos_command_line_application branch February 15, 2022 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants