Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Extension Info.plist Validation #1946

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

maustinstar
Copy link

This is a stacked PR dependent on #1944. To isolate the diffs from this branch, view here.

#1944 introduces support for App Extensions built with ExtensionKit by setting the attribute extensionkit_extension = True.

Issue #1943 discusses that we should catch and surface validation errors. This PR makes the extensionkit_extension attribute discoverable by providing warnings and errors with hints.

If extensionkit_extension = False (default), and we recognize an extension point identifier is intended for ExtensionKit (like com.apple.app-intents), provide a warning, and suggest setting extensionkit_extension = True. These warnings are non-blocking, since Apple may change extension type support for products.

Likewise, if extensionkit_extension = False but the Info.plist contains an EXAppExtensionAttributes entry, raise a blocking error. app-extension product types always expect the NSExtension entry, and never EXAppExtensionAttributes. Conversely, extensionkit-extension product types always expect EXAppExtensionAttributes entry, and never NSExtension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant