App Extension Info.plist Validation #1946
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stacked PR dependent on #1944. To isolate the diffs from this branch, view here.
#1944 introduces support for App Extensions built with ExtensionKit by setting the attribute
extensionkit_extension = True
.Issue #1943 discusses that we should catch and surface validation errors. This PR makes the
extensionkit_extension
attribute discoverable by providing warnings and errors with hints.If
extensionkit_extension = False
(default), and we recognize an extension point identifier is intended for ExtensionKit (likecom.apple.app-intents
), provide a warning, and suggest settingextensionkit_extension = True
. These warnings are non-blocking, since Apple may change extension type support for products.Likewise, if
extensionkit_extension = False
but the Info.plist contains anEXAppExtensionAttributes
entry, raise a blocking error.app-extension
product types always expect theNSExtension
entry, and neverEXAppExtensionAttributes
. Conversely,extensionkit-extension
product types always expectEXAppExtensionAttributes
entry, and neverNSExtension
.