Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add armeabi_cc_toolchain_config.bzl to macOS config #105

Merged
merged 2 commits into from
Jun 7, 2021
Merged

Add armeabi_cc_toolchain_config.bzl to macOS config #105

merged 2 commits into from
Jun 7, 2021

Conversation

keith
Copy link
Member

@keith keith commented May 27, 2021 •
edited
Loading

@keith keith requested review from c-mita and oquenchil as code owners May 27, 2021 20:36
@keith keith mentioned this pull request May 27, 2021
Closed
@google-cla google-cla bot added the cla: yes label May 27, 2021
oquenchil
oquenchil approved these changes May 31, 2021
View reviewed changes
Copy link
Contributor

@oquenchil oquenchil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@meteorcloudy
Copy link
Member

@oquenchil Can you import this change?

oquenchil
oquenchil approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@oquenchil oquenchil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bazel-io bazel-io merged commit daf6ace into bazelbuild:master Jun 7, 2021
@meteorcloudy meteorcloudy mentioned this pull request Dec 16, 2021
Closed
@keith keith deleted the ks/add-armeabi_cc_toolchain_config.bzl-to-macos-config branch December 16, 2021 18:25
@keith keith mentioned this pull request Dec 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oquenchil oquenchil oquenchil approved these changes

@c-mita c-mita Awaiting requested review from c-mita

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@keith @meteorcloudy @oquenchil @bazel-io