-
Notifications
You must be signed in to change notification settings - Fork 693
Allow Ignoring of pre-loaded packages. #55
Comments
Yeah, I think we can safely add a kwarg for that. I hadn't seen the rules_protobuf stuff, that has a number of interesting features. |
Determined that if I changed the ordering of my linked workspaces I circumvented this issue so this is merely a nice to have at this point. Thanks! |
This avoids manual `excludes=[]` and `overrides={}`, which were suggested in the linked issues. We exclude things that have already been imported, so to override them, simply import them before `docker_repositories()` and the exclusion logic will handle the rest. Fixes: bazelbuild#55 Fixes: bazelbuild#77
This avoids manual `excludes=[]` and `overrides={}`, which were suggested in the linked issues. We exclude things that have already been imported, so to override them, simply import them before `docker_repositories()` and the exclusion logic will handle the rest. Fixes: bazelbuild#55 Fixes: bazelbuild#77
Thank you @mattmoor! |
@promiseofcake My pleasure, sorry this was a little slow. |
No worries, thanks also for |
Same issue when attempting to build containers in a repository that has a tensorflow dependency (which is also providing that bind for Here is a related issue from the parent I can get around this with a fork, kind of, the problem is that we are depending on published artifacts for @mattmoor, do you know why we need to use the published artifacts rather than repo's targets? |
as well as Maven target/ in preparation for upcoming mvn2bazel example
Via the
docker_repositories()
initialization command it would be great if we had a way to re-use existing dependencies.Let's say for example I was attempting to build something in the
tensorflow/tensorflow
tf_workspace
, that we have loaded up. It turns out they have already importedsix
:https://github.com/tensorflow/tensorflow/blob/master/tensorflow/workspace.bzl#L302
Without being able to override in some manner we are unable to use the
docker_build
rules in the same workspace. pubref/rules_protobuf an interesting way to handle these sorts of dependencies:https://github.com/pubref/rules_protobuf#overriding-or-excluding-workspace-dependencies
Which then uses some
require
logic under the hood to load / not load the repository functions.In interim I suppose it's possible to manually include the dependencies other than the ones we have already defined and go from there. This seems like something that might get solved as we move towards: bazelbuild/bazel#1943
The text was updated successfully, but these errors were encountered: