Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1022 update readme with details on known issue #1042

Merged
merged 5 commits into from Aug 7, 2019
Merged

Issue 1022 update readme with details on known issue #1042

merged 5 commits into from Aug 7, 2019

Conversation

raulAtNines
Copy link
Contributor

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@raulAtNines raulAtNines changed the title Issue 1022 update readme Issue 1022 update readme with details on known issue Jul 31, 2019
@nlopezgi
Copy link
Contributor

Thanks for sending this PR. Can you please do the CLA as indicated above and then we can merge?
Thanks again

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jul 31, 2019
@nlopezgi
Copy link
Contributor

/gcbrun

@raulAtNines
Copy link
Contributor Author

@nlopezgi Our corporate CLA has been signed, I should get it cleared soon. Thank you.

@raulAtNines
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Aug 7, 2019
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Aug 7, 2019
@raulAtNines
Copy link
Contributor Author

@googlebot I signed it!

@raulAtNines
Copy link
Contributor Author

@nlopezgi The CLA was approved. I think I messed it up by updating the PR to latest master. Can you help with that? It's otherwise ready.

@nlopezgi
Copy link
Contributor

nlopezgi commented Aug 7, 2019

thanks, looks like the cla bot is somehow stuck. Given this PR has a trace of you accepting the CLA, I can manually squash and merge overriding the check.

@nlopezgi
Copy link
Contributor

nlopezgi commented Aug 7, 2019

/gcbrun

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nlopezgi, raulAtNines

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@raulAtNines
Copy link
Contributor Author

Great! Thanks.

@nlopezgi nlopezgi merged commit 296ba26 into bazelbuild:master Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants