This repository has been archived by the owner on Oct 2, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`go_repository` git `commit` doesn't support `http_load` caching mechanism thus prevents `rules_docker` to be used in air gapped environment. Replacing it with alternative `urls` address makes go_repository to use `http_load` and utilize [caching mechanism](https://docs.bazel.build/versions/master/guide.html#running-bazel-in-an-airgapped-environment) if needed. An additional piece of information will be needed in future for updating dependencies' versions - sha256. The way to get sha256 on mac - to download the file from `https://api.github.com/repos/<org>/<repo>/tarball/<commit>` and running `shasum -a 256 <file>`
/assign @smukherj1 |
smukherj1
approved these changes
Sep 11, 2020
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smartkiwi, smukherj1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/gcbrun |
cgdolan
pushed a commit
to cgdolan/rules_docker
that referenced
this pull request
Sep 13, 2020
`go_repository` git `commit` doesn't support `http_load` caching mechanism thus prevents `rules_docker` to be used in air gapped environment. Replacing it with alternative `urls` address makes go_repository to use `http_load` and utilize [caching mechanism](https://docs.bazel.build/versions/master/guide.html#running-bazel-in-an-airgapped-environment) if needed. An additional piece of information will be needed in future for updating dependencies' versions - sha256. The way to get sha256 on mac - to download the file from `https://api.github.com/repos/<org>/<repo>/tarball/<commit>` and running `shasum -a 256 <file>`
jamiees2
pushed a commit
to jamiees2/rules_docker
that referenced
this pull request
Sep 23, 2020
`go_repository` git `commit` doesn't support `http_load` caching mechanism thus prevents `rules_docker` to be used in air gapped environment. Replacing it with alternative `urls` address makes go_repository to use `http_load` and utilize [caching mechanism](https://docs.bazel.build/versions/master/guide.html#running-bazel-in-an-airgapped-environment) if needed. An additional piece of information will be needed in future for updating dependencies' versions - sha256. The way to get sha256 on mac - to download the file from `https://api.github.com/repos/<org>/<repo>/tarball/<commit>` and running `shasum -a 256 <file>`
@smartkiwi, is this something that could be accomplished using a Remote Asset API? I haven't ever worked in an airgapped environment so I don't really know much about the difficulties encountered here. This change is probably ok to make anyway. Something else to look forward to for your use case is the External Dep Overhaul. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go_repository
gitcommit
doesn't supporthttp_load
caching mechanism thus preventsrules_docker
to be used in air gapped environment.Replacing it with alternative
urls
address makes go_repository to usehttp_load
and utilize caching mechanism if needed.An additional piece of information will be needed in future for updating dependencies' versions - sha256.
The way to get sha256 on mac - to download the file from
https://api.github.com/repos/<org>/<repo>/tarball/<commit>
and runningshasum -a 256 <file>