This repository has been archived by the owner on Oct 2, 2023. It is now read-only.
Use bash from the environment instead of absolute path #1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all operating systems ship with bash located at `/bin/bash`. Change the interpreter to `/usr/bin/env bash` to request bash from the environment.
smukherj1
approved these changes
Oct 23, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kalbasit, smukherj1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/gcbrun |
|
CI is failing due to a known infra issue. Will need to retry tomorrow |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all operating systems ship with bash located at
/bin/bash. Change the interpreter to/usr/bin/env bashto request bash from the environment.For instance, I use NixOS as my daily driver and this operating system does not follow FHS; In fact it does not have a
/binand the only thing in/usr/binisenv.Related to bazel-contrib/rules_go#2295