This repository has been archived by the owner on Oct 2, 2023. It is now read-only.
Removed bazel_latest
from default dependencies
#1813
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The
bazel_latest
image takes quite a bit of time to fetch (Fetching @bazel_latest; fetching 65s
or more) which causes undesired slowness when performing Bazelsync
and adds a sizable dependency which is never used. To my knowledge, this image is only used for testing:rules_docker/contrib/repro_test.bzl
Lines 266 to 279 in 6c3c59b
Users should not be forced to include this dependency in their workspace unless it's needed for a public facing rule.
Issue Number: N/A
What is the new behavior?
The
images
macro is no longer called in thedeps
macro. This prevents thebazel_latest
image from being added to users workspace when loadingcontainer_deps
per the Setup documentation.Does this PR introduce a breaking change?
Users who depend on this image will now have to load it explicitly via:
Though, it would have been in user's best interest to load this image themselves in the first place because this image does not provide a digest and therefore isn't cached as effectively as it should be.
Other information