This repository has been archived by the owner on Oct 2, 2023. It is now read-only.
Propagate tags to app-layers in docker images for all langs #1836
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
We are using
py3_image()
withlayers
parameter in one of our projects. These images havetags = ["manual"]
so we don't expect them to build withbazel build //...
. However, we observing that.tar
files with layers are still built. That happened because tags were not propagated to the layer's targets. This PR is trying to fix the issue.Issue Number: N/A
What is the new behavior?
bazel build //...
doesn't build extra targets like layers when manual tag is used.Does this PR introduce a breaking change?
Other information