This repository has been archived by the owner on Oct 2, 2023. It is now read-only.
feat(toolchain): add xz_target for remote execution #1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibfahn
requested review from
alexeagle,
gravypod,
pcj and
smukherj1
as code owners
gibfahn
force-pushed
the
xz_target
branch
18 times, most recently
from
d4c260b
to
69a9ab9
Compare
Copied what is currently done for gzip_target.
|
Thanks @alexeagle ! |
12 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a re-opening of #1559, which was closed due to inactivity.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
You cannot provide the
xzdependency via a Bazel http_archive, instead you must havexzalready installed on the system, which is not feasible in heterogeneous build environments.What is the new behavior?
Allows a hermetic xz binary to be provided.
Worth noting that busybox provides a fully static musl busybox that
should work on any Linux system, that gives you both gzip and xz.
Does this PR introduce a breaking change?
Other information
Commits (oldest to newest)
787a956 feat(toolchain): add xz_target for remote execution
Copied what is currently done for gzip_target.