-
Notifications
You must be signed in to change notification settings - Fork 691
Removed python test dependencies from public API #1905
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
It's not clear to me why the tests are failing but it appears to be affecting other PRs as well failure:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me. I think this can go in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind making sure build_tar.py still works when rules_python isn't included? There should be a test for this but I don't know if it was added into CI.
This is just me being overly cautious probably.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
The python dependencies appear to be only used by test targets. If this is the case, users should not be forced to define them. The test target should be moved to another package so the dependencies can generally be ignored.
Does this PR introduce a breaking change?
Other information