This repository has been archived by the owner on Oct 2, 2023. It is now read-only.
Add target as an attribute to dockerfile_build #1944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakegut
requested review from
alexeagle,
gravypod,
pcj and
smukherj1
as code owners
jakegut
force-pushed
the
jake/dockerfile-build-target
branch
from
93a3c04
to
2089826
Compare
|
@jakegut, mind rebasing this PR? CI should be green at head. Once it's rebased I can review (I think this looks pretty good to me). |
jakegut
force-pushed
the
jake/dockerfile-build-target
branch
from
2089826
to
05b10e7
Compare
|
@gravypod Done. |
alexeagle
approved these changes
Nov 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
I wasn't able to build a specific stage of a Dockerfile with the current implementation of
dockerfile_buildIssue Number: N/A
What is the new behavior?
You can optionally specify a
targetattribute fordockerfile_buildthat will tell docker to build to that stage. Docker documentation hereDoes this PR introduce a breaking change?
Other information