This repository has been archived by the owner on Oct 2, 2023. It is now read-only.
Don't print output of ExtractImageId mnemonics when successful #1969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These print a ton of output from arbitrary commands in the container, like dpkg spam for hundreds of lines. Well-behaved Bazel actions should be silent when successful to avoid making bazel stdout unreadable.
gravypod
approved these changes
Dec 3, 2021
alexeagle
added a commit
to alexeagle/rules_docker
that referenced
this pull request
Feb 17, 2022
Prevents RunAndCommitLayer and related actions from spamming the Bazel stdout log with Docker output, when the action succeeds. Similar to bazelbuild#1969 which did this for ExtractImageId.
alexeagle
added a commit
to alexeagle/rules_docker
that referenced
this pull request
Feb 17, 2022
Prevents RunAndCommitLayer and related actions from spamming the Bazel stdout log with Docker output, when the action succeeds. Similar to bazelbuild#1969 which did this for ExtractImageId.
12 tasks
alexeagle
added a commit
to alexeagle/rules_docker
that referenced
this pull request
Feb 17, 2022
Prevents RunAndCommitLayer and related actions from spamming the Bazel stdout log with Docker output, when the action succeeds. Similar to bazelbuild#1969 which did this for ExtractImageId. Fixes bazelbuild#2006
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These print a ton of output from arbitrary commands in the container, like dpkg spam for hundreds of lines.
Well-behaved Bazel actions should be silent when successful to avoid making bazel stdout unreadable.