Skip to content
This repository has been archived by the owner on Oct 2, 2023. It is now read-only.

Allow support for WORKSPACE.bazel files #1992

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Allow support for WORKSPACE.bazel files #1992

merged 1 commit into from
Jan 3, 2022

Conversation

UebelAndre
Copy link
Contributor

@UebelAndre UebelAndre commented Jan 3, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #1902

What is the new behavior?

Users can now use WORKSPACE.bazel files by setting go_repository_default_config:

load("@io_bazel_rules_docker//repositories:deps.bzl", container_deps = "deps")

container_deps(
    # https://github.com/bazelbuild/rules_docker/issues/1902
    go_repository_default_config = "@//:WORKSPACE.bazel"
)

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@UebelAndre UebelAndre marked this pull request as ready for review January 3, 2022 05:26
Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sigh, the messes

@UebelAndre
Copy link
Contributor Author

For the paper trail. This change could probably be removed depending on the outcome of #1787

@alexeagle alexeagle merged commit 2e18897 into bazelbuild:master Jan 3, 2022
@UebelAndre UebelAndre deleted the dot branch January 3, 2022 05:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants