Skip to content
This repository has been archived by the owner on Oct 2, 2023. It is now read-only.

Update container-structure-test binaries to v0.11.0 #2013

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

dbrian
Copy link
Contributor

@dbrian dbrian commented Feb 3, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Version 1.9.1 of the container-structure-test-darwin-amd64 binary is not compatible with MacOS Monterey.

❯ ./container-structure-test-darwin-amd64
fatal error: runtime: bsdthread_register error

runtime stack:
runtime.throw(0x15e1aff, 0x21)
	/usr/local/go/src/runtime/panic.go:605 +0x95 fp=0x7ff7bfeff6f0 sp=0x7ff7bfeff6d0 pc=0x102a1b5
runtime.goenvs()
	/usr/local/go/src/runtime/os_darwin.go:108 +0x83 fp=0x7ff7bfeff720 sp=0x7ff7bfeff6f0 pc=0x1027a53
runtime.schedinit()
	/usr/local/go/src/runtime/proc.go:492 +0xa4 fp=0x7ff7bfeff760 sp=0x7ff7bfeff720 pc=0x102cb94
runtime.rt0_go(0x7ff7bfeff798, 0x1, 0x7ff7bfeff798, 0x0, 0x1000000, 0x1, 0x7ff7bfeff978, 0x0, 0x7ff7bfeff9a0, 0x7ff7bfeff9dc, ...)
	/usr/local/go/src/runtime/asm_amd64.s:175 +0x1eb fp=0x7ff7bfeff768 sp=0x7ff7bfeff760 pc=0x105452b

Issue Number: #2012

What is the new behavior?

Version 1.11.0 works as expected.

❯ ./container-structure-test-darwin-amd64
container-structure-test provides a powerful framework to validate
the structure of a container image.
These tests can be used to check the output of commands in an image,
as well as verify metadata and contents of the filesystem.

Usage:
  container-structure-test [command]

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@marcguilera
Copy link

This solves the issue for me

@jotadrilo
Copy link

Hello there! This patch works like a charm for me too. Do we guys plan to include this in the next release?

@jcourteau
Copy link

This may be sufficient to re-enable the tests that were disabled in #1952

Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@alexeagle alexeagle merged commit 7281c05 into bazelbuild:master Jun 8, 2022
St0rmingBr4in pushed a commit to St0rmingBr4in/rules_docker that referenced this pull request Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants