Upgrade rules_go and Gazelle #2035
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linzhp
requested review from
smukherj1,
alexeagle,
pcj and
gravypod
as code owners
alexeagle
reviewed
Mar 1, 2022
|
|
||
| # TODO: `go_repository_default_config` is only useful for working around | ||
| # https://github.com/bazelbuild/rules_docker/issues/1902 and could likely be | ||
| # removed after https://github.com/bazelbuild/rules_docker/issues/1787 | ||
| def go_deps(go_repository_default_config = "@//:WORKSPACE"): | ||
| def go_deps(): |
There was a problem hiding this comment.
this looks like a breaking change for users?
|
FWIW: I'm currently using this on an M1 Mac to successfully cross-compile linux_amd64 containers using Bazel 4.2.2 |
|
This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. |
github-actions
bot
added
the
Can Close?
|
This PR was automatically closed because it went 30 days without a reply since it was labeled "Can Close?" |
|
Why is this PR close? people using M1 host seem to have issues with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
rules_go and Gazelle are pretty old
Issue Number: #2036
What is the new behavior?
Does this PR introduce a breaking change?
Other information
New rules_go no longer allows to call
go_register_toolchainsmultiple times, so we have to move it out ofgo_deps, because it will be called another time inpython/image.bzl.