Skip to content
This repository has been archived by the owner on Oct 2, 2023. It is now read-only.

Replace python with python3 in incremental_load.sh.tpl #2051

Merged
merged 2 commits into from
Apr 15, 2022

Conversation

jbgosselin
Copy link
Contributor

@jbgosselin jbgosselin commented Mar 29, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

On MacOS 12.3, Apple removed the default python executable.
Building images doesn't work and throw this error:
env: python: No such file or directory

Issue Number: #2046 2046

What is the new behavior?

Build on a system without python executable (as MacOS 12.3+) works as expected.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla
Copy link

google-cla bot commented Mar 29, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@linzhp linzhp self-assigned this Apr 13, 2022
Copy link
Collaborator

@linzhp linzhp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you sign CLA?

@jbgosselin
Copy link
Contributor Author

I think I did sign it @linzhp

container/incremental_load.sh.tpl Outdated Show resolved Hide resolved
Co-authored-by: Zhongpeng Lin <zplin@uber.com>
@jbgosselin jbgosselin requested a review from linzhp April 15, 2022 15:57
@linzhp linzhp merged commit b301740 into bazelbuild:master Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants