This repository has been archived by the owner on Oct 2, 2023. It is now read-only.
Keep the same behaviour for the 'base' argument between the rule container_image and its implementation function (#2083)
#2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
gravypod,
linzhp,
pcj,
smukherj1 and
uhthomas
as code owners
ghost
changed the title
container_image and its implementation function (#2083)
…its implementation function (#2083) Really override the ctx.attr.base attribute with the 'base' argument of the implementattion function of the `container_image` rule.
gravypod
approved these changes
Jun 3, 2022
St0rmingBr4in
pushed a commit
to St0rmingBr4in/rules_docker
that referenced
this pull request
Oct 17, 2022
…its implementation function (bazelbuild#2083) (bazelbuild#2084) Really override the ctx.attr.base attribute with the 'base' argument of the implementattion function of the `container_image` rule.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really override the ctx.attr.base attribute with the 'base' argument of
the implementattion function of the
container_imagerule.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #2083
What is the new behavior?
We can give the same object type to the
baseargument of thecontainer_imageimplementation function than thebaseattribute of the associated rule.Does this PR introduce a breaking change?