Skip to content
This repository has been archived by the owner on Oct 2, 2023. It is now read-only.

Attempt to fix #363 #380

Closed
wants to merge 1 commit into from
Closed

Attempt to fix #363 #380

wants to merge 1 commit into from

Conversation

philwo
Copy link
Member

@philwo philwo commented Apr 9, 2018

Seems like the solution agreed upon in #363 was to simply remove the __init__.py files from the list of expected files.

@mattmoor
Copy link
Contributor

Can you rebase?

@philwo
Copy link
Member Author

philwo commented Apr 12, 2018

Can you rebase?

Done!

@mattmoor
Copy link
Contributor

According to Travis this is still failing with 0.12?

$ sudo -E apt-get -yq --no-install-suggests --no-install-recommends --force-yes install bazel
...
Get:1 http://storage.googleapis.com/bazel-apt stable/jdk1.8 amd64 bazel amd64 0.12.0 [95.5 MB]

Here's the error output:

...
//container:image_test                                                   FAILED in 50.9s
  /home/travis/.cache/bazel/_bazel_travis/d0ff5f3cca735acf503b43d534fda185/execroot/io_bazel_rules_docker/bazel-out/k8-fastbuild/testlogs/container/image_test/test.log
Executed 4 out of 4 tests: 3 tests pass and 1 fails locally.
There were tests whose specified size is too big. Use the --test_verbose_timeout_warnings command line option to see which ones these are.
The command "bazel clean && bazel test --test_output=errors //..." exited with 3.

@xingao267
Copy link
Member

@erain is working on fix the Travis CI. It looks like the assertion looks for an exact match, and also looks for './app/testdata/py_image.binary.runfiles/io_bazel_rules_docker/testdata/init.py'. I sent #399 trying to fix it.

@xingao267
Copy link
Member

Fixed in #399. Please reopen if there is any concern.

@xingao267 xingao267 closed this May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants