Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sha256 from dependencies fetched from codeload.github.com #824

Merged
merged 2 commits into from
Sep 12, 2017

Conversation

jayconrod
Copy link
Contributor

This is a cherry-pick of #823 onto a new branch, release/0.5.5 which is
based on tag 0.5.4.


These archives are prepared on-the-fly by GitHub and are not
guaranteed to be the same every time (for example, the order of files
within the archive could change).

All archives are fetched over https; this should be as secure as
git_repository and still faster.

Related #820

[skip ci]
[ci skip]

…elbuild#823)

These archives are prepared on-the-fly by GitHub and are not
guaranteed to be the same every time (for example, the order of files
within the archive could change).

All archives are fetched over https; this should be as secure as
git_repository and still faster.

Related bazelbuild#820
@nlacasse
Copy link

You also need to remove the sha for go_proto_repositories from this file:

https://github.com/bazelbuild/rules_go/blob/0.5.4/proto/go_proto_library.bzl#L336

@jayconrod
Copy link
Contributor Author

@nlacasse Oops, not sure how I missed that one. Thanks for pointing that out.

@jayconrod jayconrod merged commit 2ffc49e into bazelbuild:release/0.5.5 Sep 12, 2017
@jayconrod jayconrod deleted the release-0.5.5 branch September 12, 2017 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants