using python_version to try issues with 0.25.0rc1 #306
Conversation
nlopezgi
requested review from
alex1545,
chrislovecnm,
erain,
smukherj1 and
xingao267
as code owners
|
Please dont review yet. Just for discussion for now. fyi @brandjon |
|
/test pull-rules-k8s-e2e |
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
/retest |
|
/test pull-rules-k8s-e2e |
WORKSPACE
Outdated
| # can be removed once other dependencies are updated. | ||
| git_repository( | ||
| name = "subpar", | ||
| commit = "0356bef3fbbabec5f0e196ecfacdeb6db62d48c0", # 2019-03-07 | ||
| commit = "9c7b3e73b2c1f2befb3a789194bb46982ea336c8", # 2019-05-13 |
There was a problem hiding this comment.
I just tagged subpar 2.0.0, so you can replace this line with tag = "2.0.0",.
|
/lgtm |
|
@nlopezgi: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nlopezgi, smukherj1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
context: #305
Creating PR to discuss issues related to 0.25.0rc1 with stakeholders.
Note this will fail until Bazel 0.25.0 is out