Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Make the kubectl toolchain type public #624

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

person142
Copy link
Contributor

@person142 person142 commented Nov 18, 2020

Closes #530.

This allows defining your own kubectl toolchains; e.g.

# //:BUILD
toolchain(
    name = "my_kubectl_toolchain",
    target_compatible_with = ...,
    toolchain = "//my/local:kubectl",
    toolchain_type = "@io_bazel_rules_k8s//toolchains/kubectl:toolchain_type",
)
# WORKSPACE
...

load("@io_bazel_rules_k8s//k8s:k8s.bzl", "k8s_repositories")

k8s_repositories()

load("@io_bazel_rules_k8s//k8s:k8s_go_deps.bzl", k8s_go_deps = "deps")

k8s_go_deps()

register_toolchains(
    "//:my_kubectl_toolchain",
)

which then allows more flexibility over what kubectl_configure currently allows.

@k8s-ci-robot
Copy link

Hi @person142. Thanks for your PR.

I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@person142 person142 force-pushed the kubectl-toolchain-public branch from 6d13df8 to 78d7353 Compare November 18, 2020 16:27
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, person142

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta
Copy link
Contributor

fejta commented Nov 18, 2020

/ok-to-test

@person142
Copy link
Contributor Author

/retest

2 similar comments
@fejta
Copy link
Contributor

fejta commented Nov 18, 2020

/retest

@person142
Copy link
Contributor Author

/retest

@person142
Copy link
Contributor Author

(Third time is the charm? 🤞)

@person142
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link

@person142: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-rules-k8s-e2e 78d7353 link /test pull-rules-k8s-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fejta fejta merged commit f1c6399 into bazelbuild:master Jan 6, 2021
@person142 person142 deleted the kubectl-toolchain-public branch January 7, 2021 03:00
@person142
Copy link
Contributor Author

Thanks @fejta!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubectl toolchain_type //visibility:public ?
3 participants