Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Resolver library #628

Merged
merged 5 commits into from
Apr 30, 2021
Merged

Resolver library #628

merged 5 commits into from
Apr 30, 2021

Conversation

mariusgrigoriu
Copy link
Contributor

There are times you may want a custom resolver, but not re-implement all of the behavior that exists in the one provided by rules_k8s. You could chain resolvers by executing the one from rules_k8s, but it would be nice if you could import it as a go package.

This PR moves the resolver into a library that custom Go resolvers can easily reuse to register flags and then pass execution to the rules_k8s resolver after performing custom processing.

@k8s-ci-robot
Copy link

Hi @mariusgrigoriu. Thanks for your PR.

I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mariusgrigoriu mariusgrigoriu changed the title Resolver as package Resolver library Dec 13, 2020
@chases2
Copy link
Contributor

chases2 commented Dec 14, 2020

/ok-to-test
This looks like a fine refactoring to me, but I'd like another set of eyes on this.
/assign @fejta

@fejta
Copy link
Contributor

fejta commented Apr 30, 2021

/test all

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, mariusgrigoriu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta fejta merged commit faa17f2 into bazelbuild:master Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants