-
Notifications
You must be signed in to change notification settings - Fork 136
Conversation
Hi @UebelAndre. Thanks for your PR. I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @chizhg |
/ok-to-test |
/retest |
@chases2 Any way to help resolve
? |
rules_k8s/images/gcloud-bazel/Makefile Lines 18 to 19 in 002b365
The image has 2.2.0 and 3.0.0. Can we start by upgrading to 3.0.0? Changing to
|
Trying 3.0.0 but it feels kinda bad given it's already a year old. In this PR I added a test to run on |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fejta, UebelAndre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
If you give me a valid tag I can use for |
I actually have no idea who would make that or how to get one. Is there a Googler you could reach out to? |
Oh, I messed up the commit message, 3.0.0 is not an LTS release :( |
I believe the latest that exists there is 3.5.0 |
Right but who publishes those? I feel like a 4.0.0 image is warranted but I feel that's less urgent since 4.0.0 was confirmed to work in this PR. edit: A request for this image can be found at GoogleCloudPlatform/container-definitions#12037 |
This reverts commit 73f62de.
This PR adds Bazel 3.0.0 support by updating various dependencies.