Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Add support for Bazel 3.0.0 #639

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Add support for Bazel 3.0.0 #639

merged 1 commit into from
Apr 21, 2021

Conversation

UebelAndre
Copy link
Contributor

@UebelAndre UebelAndre commented Mar 2, 2021

This PR adds Bazel 3.0.0 support by updating various dependencies.

@k8s-ci-robot
Copy link

Hi @UebelAndre. Thanks for your PR.

I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@UebelAndre
Copy link
Contributor Author

/assign @chizhg

@UebelAndre UebelAndre changed the title Updated Bazel version to LTS version 4.0.0 Add support for Bazel LTS version 4.0.0 Mar 2, 2021
@chases2 chases2 requested review from chizhg and removed request for chases2 March 2, 2021 17:16
@chases2
Copy link
Contributor

chases2 commented Apr 20, 2021

/ok-to-test

@UebelAndre
Copy link
Contributor Author

/retest

@UebelAndre
Copy link
Contributor Author

@chases2 Any way to help resolve

ERROR: The project you're trying to build requires Bazel 4.0.0 (specified in /home/prow/go/src/github.com/bazelbuild/rules_k8s/.bazelversion), but it wasn't found in /usr/local/lib/bazel/bin.

?

@fejta
Copy link
Contributor

fejta commented Apr 21, 2021

OLD ?= 2.2.0
NEW ?= 3.0.0

The image has 2.2.0 and 3.0.0. Can we start by upgrading to 3.0.0? Changing to NEW = 4.0.0 fails:

Step #0: Step 4/14 : FROM launcher.gcr.io/google/bazel:${NEW_VERSION}
Step #0: manifest for launcher.gcr.io/google/bazel:4.0.0 not found: manifest unknown: Failed to fetch "4.0.0" from request "/v2/google/bazel/manifests/4.0.0".
Finished Step #0
ERROR
ERROR: build step 0 "gcr.io/cloud-builders/docker" failed: step exited with non-zero status: 1
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

ERROR: (gcloud.builds.submit) build e75d50d1-1986-4e4d-adb3-1ea8269c42f2 completed with status "FAILURE"

@UebelAndre
Copy link
Contributor Author

The image has 2.2.0 and 3.0.0. Can we start by upgrading to 3.0.0? Changing to NEW = 4.0.0 fails:

Trying 3.0.0 but it feels kinda bad given it's already a year old. In this PR I added a test to run on 2.2.0 to ensure previous versions of Bazel still work. The thing we don't know is if newer ones also work (but we know whatever runs in BuildKite does though). I think it'd be beneficial to setup min supported and latest e2e tests.

@UebelAndre UebelAndre changed the title Add support for Bazel LTS version 4.0.0 Add support for Bazel 3.0.0 Apr 21, 2021
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, UebelAndre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta
Copy link
Contributor

fejta commented Apr 21, 2021

If you give me a valid tag I can use for launcher.gcr.io/google/bazel:4.0.0 then I can create an image that has bazel 4.x.y and 3.0.0 (at which point we should probably update the min supported version to 3.0.0)

@fejta fejta merged commit 73f62de into bazelbuild:master Apr 21, 2021
@UebelAndre
Copy link
Contributor Author

If you give me a valid tag I can use for launcher.gcr.io/google/bazel:4.0.0 then I can create an image that has bazel 4.x.y and 3.0.0 (at which point we should probably update the min supported version to 3.0.0)

I actually have no idea who would make that or how to get one. Is there a Googler you could reach out to?

@UebelAndre UebelAndre deleted the lts branch April 21, 2021 23:30
@UebelAndre
Copy link
Contributor Author

Oh, I messed up the commit message, 3.0.0 is not an LTS release :(

@fejta
Copy link
Contributor

fejta commented Apr 22, 2021

I believe the latest that exists there is 3.5.0

@UebelAndre
Copy link
Contributor Author

UebelAndre commented Apr 22, 2021

I believe the latest that exists there is 3.5.0

Right but who publishes those? I feel like a 4.0.0 image is warranted but I feel that's less urgent since 4.0.0 was confirmed to work in this PR.

edit: A request for this image can be found at GoogleCloudPlatform/container-definitions#12037

fejta added a commit to fejta/rules_k8s that referenced this pull request Apr 30, 2021
@fejta fejta mentioned this pull request Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants