-
Notifications
You must be signed in to change notification settings - Fork 136
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rajatvig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @rajatvig. Thanks for your PR. I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
k8s/k8s.bzl
Outdated
@@ -51,7 +51,7 @@ def k8s_repositories(): | |||
http_archive, | |||
name = "com_github_yaml_pyyaml", | |||
build_file_content = _com_github_yaml_pyyaml_build_file, | |||
sha256 = "e9df8412ddabc9c21b4437ee138875b95ebb32c25f07f962439e16005152e00e", | |||
sha256 = "ba59d7e97eb131d8f8f52d19cb124bb67772f4c7f4d14cb2919deb885ef8c572", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any insight into why/when the sha changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/retest |
I suspect we'll need to wait for various caches to become consistent again. |
Very likely but unsure. To test, just downloaded the archive and it has the new SHA. Ran a clean bazel build with a local patch for it and that too used the new SHA. |
while true; do curl --silent -L https://github.com/yaml/pyyaml/archive/5.1.2.zip | shasum -a 256; sleep 2; done Try that and see if you get consistent results. It seems to vary based on location and ISP... hopefully it trickles through all the various CDNs |
/retest |
1 similar comment
/retest |
@fejta From what it looks like, most caches have now got it fixed. |
/retest |
Can you drop the last two commits from this PR? (alternatively click rebuild on buildkite to rerun the build) |
@fejta Dropped the two commits but I do not have rights to rebuild |
/retest |
@fejta Could you retrigger the tests? |
/retest |
/retest-required |
@rajatvig: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Mostly superseded by #697 |
No description provided.