Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Support M1 #683

Closed
wants to merge 1 commit into from
Closed

Support M1 #683

wants to merge 1 commit into from

Conversation

rajatvig
Copy link

@rajatvig rajatvig commented Feb 1, 2022

No description provided.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rajatvig
To complete the pull request process, please assign fejta after the PR has been reviewed.
You can assign the PR to them by writing /assign @fejta in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @rajatvig. Thanks for your PR.

I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rajatvig rajatvig changed the title Support M1 + PyYaml fix Support M1 Feb 1, 2022
@rajatvig rajatvig changed the title Support M1 Support M1 + PyYaml fix Feb 1, 2022
@fejta
Copy link
Contributor

fejta commented Feb 1, 2022

/ok-to-test

k8s/k8s.bzl Outdated
@@ -51,7 +51,7 @@ def k8s_repositories():
http_archive,
name = "com_github_yaml_pyyaml",
build_file_content = _com_github_yaml_pyyaml_build_file,
sha256 = "e9df8412ddabc9c21b4437ee138875b95ebb32c25f07f962439e16005152e00e",
sha256 = "ba59d7e97eb131d8f8f52d19cb124bb67772f4c7f4d14cb2919deb885ef8c572",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any insight into why/when the sha changed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it has been fixed. Will revert. This has the info. There is chat in the issue as well

@fejta
Copy link
Contributor

fejta commented Feb 1, 2022

/retest

@fejta fejta closed this Feb 1, 2022
@fejta fejta reopened this Feb 1, 2022
@fejta
Copy link
Contributor

fejta commented Feb 1, 2022

I suspect we'll need to wait for various caches to become consistent again.

@rajatvig
Copy link
Author

rajatvig commented Feb 1, 2022

I suspect we'll need to wait for various caches to become consistent again.

Very likely but unsure. To test, just downloaded the archive and it has the new SHA. Ran a clean bazel build with a local patch for it and that too used the new SHA.

@moriarty
Copy link

moriarty commented Feb 2, 2022

I suspect we'll need to wait for various caches to become consistent again.

Very likely but unsure. To test, just downloaded the archive and it has the new SHA. Ran a clean bazel build with a local patch for it and that too used the new SHA.

while true; do curl --silent -L https://github.com/yaml/pyyaml/archive/5.1.2.zip | shasum -a 256; sleep 2; done

Try that and see if you get consistent results. It seems to vary based on location and ISP... hopefully it trickles through all the various CDNs

@fejta
Copy link
Contributor

fejta commented Feb 2, 2022

/retest

1 similar comment
@rajatvig
Copy link
Author

rajatvig commented Feb 2, 2022

/retest

@rajatvig rajatvig changed the title Support M1 + PyYaml fix Support M1 Feb 3, 2022
@rajatvig
Copy link
Author

rajatvig commented Feb 3, 2022

@fejta From what it looks like, most caches have now got it fixed.

@rajatvig
Copy link
Author

rajatvig commented Feb 3, 2022

/retest

@fejta fejta closed this Feb 3, 2022
@fejta fejta reopened this Feb 3, 2022
@fejta
Copy link
Contributor

fejta commented Feb 3, 2022

Can you drop the last two commits from this PR? (alternatively click rebuild on buildkite to rerun the build)

@fejta fejta closed this Feb 3, 2022
@fejta fejta reopened this Feb 3, 2022
@rajatvig
Copy link
Author

rajatvig commented Feb 4, 2022

@fejta Dropped the two commits but I do not have rights to rebuild

@rajatvig
Copy link
Author

rajatvig commented Feb 7, 2022

/retest

@rajatvig
Copy link
Author

@fejta Could you retrigger the tests?

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@rajatvig
Copy link
Author

/retest

@rajatvig
Copy link
Author

/retest-required

@k8s-ci-robot
Copy link

@rajatvig: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-rules-k8s-e2e 485b4d3 link true /test pull-rules-k8s-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fejta
Copy link
Contributor

fejta commented Jun 13, 2022

Mostly superseded by #697

@fejta fejta closed this Jun 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants