Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add android example app to farm initial issues and for e2e testing. #21

Closed
hsyed opened this issue Feb 13, 2018 · 3 comments
Closed

Add android example app to farm initial issues and for e2e testing. #21

hsyed opened this issue Feb 13, 2018 · 3 comments
Assignees
Labels

Comments

@hsyed
Copy link
Contributor

hsyed commented Feb 13, 2018

Note:

Purpose:

  • End-to-End Tests for interaction with the native android rules.
  • Test app for validating the intellij and android studio plugins.
  • Farming issues with the rules that need to be made for android. This include discovering new macros that might be needed.

Must:

  • Exercise all appropriate rule orchestrations between the kt_jvm_* and the android rules.
  • Stay within the android SDK as much as possible, we don't add the entire universe as external (maven) deps -- if we need a lot of external deps we should consider bazel-deps or spotify/bazel-tools.
  • Use an external version of the android SDK --e.g., http_archive.
  • Wire up the android SDK in a way so that the recommended SDK version is used with the recommended Bazel version for CI testing -- in other words build flags, config settings and select.
  • (in addition to android studio) be compilable and navigable in intellij CE or ultimate, at least the Kotlin code.
  • Work without an IDE (this one might be obvious, but for all I know there is coupling with android studio).
@hsyed
Copy link
Contributor Author

hsyed commented Feb 14, 2018

@davidstanke I'll assign this to you since I don't do any android development internally. I doubt much nitty gritty rule development work needs to occur, we might end up with some android specific macros.

@cgruber are you interested in taking a stab at this one ? If we do need to add android specific macros all design questions will probably go to you.

@cgruber
Copy link
Collaborator

cgruber commented Feb 14, 2018 via email

@hsyed
Copy link
Contributor Author

hsyed commented Aug 13, 2018

Android is now supported(#117 ), it was easier then I anticipated. I need a proper sample project to verify everything is working as intended.

@hsyed hsyed closed this as completed Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants