Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge_plugin_infos flattens the depsets at analysis time. #289

Closed
restingbull opened this issue Feb 24, 2020 · 1 comment · Fixed by #292
Closed

merge_plugin_infos flattens the depsets at analysis time. #289

restingbull opened this issue Feb 24, 2020 · 1 comment · Fixed by #292
Assignees
@restingbull
Labels
component: android component: jvm P2 status: open - in progress type: performance Performance improvement

Comments

@restingbull
Copy link
Collaborator

Either remove or refactor.

Flattening the depsets costs memory and can result in slow downs on large build graphs.
@restingbull restingbull added the type: cleanup Refactorings, idiomatic transforms, tech debt payoff label Feb 24, 2020
@restingbull restingbull self-assigned this Feb 24, 2020
@restingbull
Copy link
Collaborator Author

For those following along at home, see https://docs.bazel.build/versions/2.0.0/skylark/performance.html#use-depsets for the reasoning.

restingbull pushed a commit to restingbull/rules_kotlin that referenced this issue Feb 27, 2020
Change plugins to use depsets, as opposed to lists. This scales bette…
7a75ee0 
…r in Bazel.

Issue: bazelbuild/issues/289
restingbull pushed a commit to restingbull/rules_kotlin that referenced this issue Feb 27, 2020
Change plugins to use depsets, as opposed to lists. This scales bette…
5d7ca0c 
…r in Bazel.

Issue: bazelbuild/issues/289
@restingbull restingbull mentioned this issue Feb 27, 2020
Merged
@cgruber cgruber added component: android component: jvm P2 status: open - in progress type: performance Performance improvement and removed type: cleanup Refactorings, idiomatic transforms, tech debt payoff labels Feb 27, 2020
cgruber pushed a commit that referenced this issue Feb 28, 2020
@restingbull
Change plugins to use depsets, as opposed to lists. (#292)
2cb1be9 
Fixes #289
cromwellian pushed a commit to cromwellian/rules_kotlin that referenced this issue Mar 7, 2020
@restingbull @cromwellian
Change plugins to use depsets, as opposed to lists. (bazelbuild#292)
7389481 
Fixes bazelbuild#289
jongerrish added a commit to jongerrish/rules_kotlin that referenced this issue Apr 16, 2020
@jongerrish
Change plugins to use depsets, as opposed to lists. (bazelbuild#292)
97d984c 
Fixes bazelbuild#289
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@restingbull restingbull

Labels
component: android component: jvm P2 status: open - in progress type: performance Performance improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change plugins to use depsets, as opposed to lists. restingbull/rules_kotlin
2 participants
@cgruber @restingbull