Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find a way to get rid of thekt_kvm_import rule. #4

Closed
hsyed opened this issue Jan 31, 2018 · 1 comment
Closed

Find a way to get rid of thekt_kvm_import rule. #4

hsyed opened this issue Jan 31, 2018 · 1 comment
Labels
component: jvm

Comments

@hsyed
Copy link
Contributor

hsyed commented Jan 31, 2018 •
edited
Loading

I recently added kotlin_import and have it marked as experimental. This rule should not be needed. as java_import and java_library are sufficient to introduce jars into the workspace. The Ijar/hjar tools strips parts of the Kotlin ABI off thus breaking inlining. A workaround would be for the ABI tools to ignore Kotlin jars in the short term.

Proposal.
@hsyed hsyed changed the title Find a way to get rid of thekotlin_import rule. Find a way to get rid of thekt_kvm_import rule. Feb 13, 2018
@hsyed
Copy link
Contributor Author

hsyed commented Jul 4, 2018

Can't get rid of this since the global ijar tool won't be handling ABI creation.

@hsyed hsyed closed this as completed Jul 4, 2018
@wcurrie wcurrie mentioned this issue Nov 17, 2018
Closed
NathanHowell pushed a commit to godaddy-icfp/rules_kotlin that referenced this issue Jun 21, 2019
@cgruber
Merge pull request bazelbuild#4 from cgruber/dagger_jarjar
aaa819c 
Shade dagger dep, to avoid leaking into a kapt dagger compilation.
jongerrish added a commit to jongerrish/rules_kotlin that referenced this issue Apr 16, 2020
@jongerrish
Merge pull request bazelbuild#4 from cgruber/dagger_jarjar
6447b0a 
Shade dagger dep, to avoid leaking into a kapt dagger compilation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: jvm
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hsyed