Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use launcher stub template from bazel #1082

Merged

Conversation

illicitonion
Copy link
Contributor

This was added in bazelbuild/bazel#12994 (and fixed in bazelbuild/bazel#13790).

This has been included in all Bazel releases since 5.0.0, which is the minimum supported Bazel version of rules_kotlin according to https://github.com/bazelbuild/rules_kotlin/blob/master/README.md

This prevents having a build-time dependency on access to raw.githubusercontent.com.

This was added in bazelbuild/bazel#12994 (and
fixed in bazelbuild/bazel#13790).

This has been included in all Bazel releases since 5.0.0, which is the
minimum supported Bazel version of rules_kotlin according to https://github.com/bazelbuild/rules_kotlin/blob/master/README.md

This prevents having a build-time dependency on access to
raw.githubusercontent.com.
@restingbull
Copy link
Collaborator


Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
--
  | java.lang.NullPointerException: attempted to use --release, but JAVA_HOME is not set
  | at java.base@20.0.2/java.util.Objects.requireNonNull(Objects.java:259)
  | at com.google.turbine.binder.CtSymClassBinder.bind(CtSymClassBinder.java:52)
  | at com.google.turbine.main.Main.bootclasspath(Main.java:309)
  | at com.google.turbine.main.Main.compile(Main.java:142)
  | at com.google.turbine.main.Main.compile(Main.java:133)
  | at com.google.turbine.main.Main.main(Main.java:89)
  | Target //:rules_kotlin_release failed to build


I think this is unrelated, but we should sort it out before merging.

@illicitonion
Copy link
Contributor Author

Yep, looks like something changed in Bazel CI? #1083 is similarly red.

@meteorcloudy any ideas what changed about Bazel CI that may have prompted these kind of issues?

@meteorcloudy
Copy link
Member

https://buildkite.com/bazel/rules-kotlin-kotlin

Yes, the postsubmit has been red for a while. I guess it's some incompatible change in Bazel@HEAD. The failing job is using Bazel@HEAD, try to use bazelisk --bisect to identify which change breaks you.

@restingbull restingbull merged commit cdb5b16 into bazelbuild:master Dec 8, 2023
2 checks passed
@illicitonion illicitonion deleted the stub-template-from-bazel branch December 9, 2023 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants