Add missing KotlinJvmTaskExecutorTest to the test suite #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing KotlinJvmTaskExecutorTest to the test suite
Bencodes
reviewed
Dec 10, 2023
| @@ -472,7 +472,7 @@ private val Directories.incrementalData | |||
| * Create a new [JvmCompilationTask] with sources found in the generatedSources directory. This should be run after | |||
| * annotation processors have been run. | |||
| */ | |||
| internal fun JvmCompilationTask.expandWithGeneratedSources(): JvmCompilationTask = | |||
There was a problem hiding this comment.
Internal will be visible to tests if you pass this target to the test target as an associate dependency.
There was a problem hiding this comment.
going to make it public to avoid using 4f0b728
There was a problem hiding this comment.
Forgot about the kt_bootstrap layer that these sources are wrapped in.
raghulvelusamy
commented
Dec 10, 2023
| @@ -44,11 +44,11 @@ class KotlinJvmTaskExecutorTest { | |||
|
|
|||
| assertTrue(expandedCompileTask.hasInputs()) | |||
| assertNotNull(expandedCompileTask.inputs.javaSourcesList.find { path -> | |||
| path.endsWith("a_test_1/generated_sources/AnotherGenClass.java") | |||
| path.endsWith("generated_sources/AnotherGenClass.java") | |||
There was a problem hiding this comment.
This always generates not 1 but a random number a-test-115507972808607999568. Removing the prefix here.
raghulvelusamy
force-pushed
the
patch-1
branch
from
9279002
to
2ca3c96
Compare
raghulvelusamy
force-pushed
the
patch-1
branch
from
2ca3c96
to
4f0b728
Compare
This reverts commit 4f0b728.
raghulvelusamy
force-pushed
the
patch-1
branch
from
87a67af
to
acf0263
Compare
raghulvelusamy
requested review from
ahumesky,
cgruber,
restingbull and
nkoroste
as code owners
Bencodes
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing KotlinJvmTaskExecutorTest to the test suite